Allow adding "ankisearch:" links in external programs. #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyifang
reviewed
Mar 22, 2023
ankiconnector.cpp
Outdated
| void AnkiConnector::ankiSearch( QString const & word ) | ||
| { | ||
| QString postTemplate = QString( | ||
| "{" |
|
what will happen,if no anki installed and click on the ankisearch link |
xiaoyifang
reviewed
Mar 22, 2023
|
|
||
| void AnkiConnector::ankiSearch( QString const & word ) | ||
| { | ||
| QString postTemplate = R"anki({ |
There was a problem hiding this comment.
if anki connect is not enabled ,can return directly?
There was a problem hiding this comment.
if anki connect is not enabled ,can return directly?
Cancel the operation if ankiconnect isn't enabled in settings? i'll look into it.
There was a problem hiding this comment.
Added an if that returns if ankiconnect isn't enabled in settings.
If Ankiconnect isn't running or if Anki isn't runnning, it prints "connection refused" at the bottom. |
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lets any external program create "ankisearch:" links. By clicking on such link, the Anki Browser opens with the specified query.
screencast-2023-Mar-21_21-31-06.mp4
This can be useful to check if you already have a certain word added to Anki.