Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add files via upload #3

Merged
merged 7 commits into from
Dec 30, 2019
Merged

Add files via upload #3

merged 7 commits into from
Dec 30, 2019

Conversation

xiaotong-sun
Copy link
Owner

@xiaotong-sun xiaotong-sun commented Dec 25, 2019 •
edited
Loading

No description provided.

@tonydon140
Copy link

Function names are too long!
The lack of comment.
-.-

@tonydon140
Copy link

🤪🤪

@idear1203
Copy link
Contributor

idear1203 commented Dec 26, 2019 •
edited
Loading

Function names are too long!
The lack of comment.
-.-

  1. Actually long function names won't be a problem because most of modern IDEs have name auto-completion support.
  2. Nice to add some comments. For documentation comment, reference here

@idear1203
Copy link
Contributor

Avoid using spaces and special characters such as ' in file names

idear1203
idear1203 reviewed Dec 26, 2019
View reviewed changes
week2/The system of the student's score management. v1.0.cpp Outdated Show resolved Hide resolved
week2/The system of the student's score management. v1.0.cpp Outdated Show resolved Hide resolved
week2/The system of the student's score management. v1.0.cpp Outdated Show resolved Hide resolved
week2/The system of the student's score management. v1.0.cpp Outdated Show resolved Hide resolved
week2/The system of the student's score management. v1.0.cpp Outdated Show resolved Hide resolved
week2/The system of the student's score management. v1.0.cpp Outdated Show resolved Hide resolved
week2/The system of the student's score management. v1.0.cpp Outdated Show resolved Hide resolved
week2/The system of the student's score management. v1.0.cpp Outdated Show resolved Hide resolved
week2/The system of the student's score management. v1.0.cpp Outdated Show resolved Hide resolved
week2/The system of the student's score management. v1.0.cpp Outdated Show resolved Hide resolved
@idear1203
Copy link
Contributor

I forgot to bring my phone to office today..Don't reach out to police if you cannot find me..

@xiaotong-sun
Update and rename The system of the student's score management. v1.0.…
eab595f 
…cpp to The_system_of_the_student_ score_management_v1.0.cpp
@idear1203
Copy link
Contributor

Remove spaces in the file name

@idear1203
Copy link
Contributor

Please update the PR title and description to briefly introduce what you are doing in this PR.

idear1203
idear1203 approved these changes Dec 28, 2019
View reviewed changes
Copy link
Contributor

@idear1203 idear1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me in general. See a minor issue below. Also nice to update the PR title and description.

@xiaotong-sun
Copy link
Owner Author

xiaotong-sun commented Dec 28, 2019 •
edited
Loading

The PR looks good to me in general. See a minor issue below. Also nice to update the PR title and description.

What is the pr title about？And how to write a description? What should it include?

@idear1203
Copy link
Contributor

The PR looks good to me in general. See a minor issue below. Also nice to update the PR title and description.

What is the pr title about？And how to write a description? What should it include?

The PR title and description should briefly introduce what you are doing in this PR. You can reference here for example.

@xiaotong-sun xiaotong-sun merged commit 2c1d363 into master Dec 30, 2019
@xiaotong-sun xiaotong-sun deleted the xiaotong-sun-patch-3 branch February 9, 2020 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonydon140 tonydon140 tonydon140 left review comments

@idear1203 idear1203 idear1203 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaotong-sun @tonydon140 @idear1203