Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xiaotong sun patch 2 #2

Merged
merged 8 commits into from
Dec 24, 2019
Merged

Xiaotong sun patch 2 #2

merged 8 commits into from
Dec 24, 2019

Conversation

xiaotong-sun
Copy link
Owner

No description provided.

idear1203
idear1203 reviewed Dec 23, 2019
View reviewed changes
Copy link
Contributor

@idear1203 idear1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave a few comments below

week2/exercise P1008 in LuoGu.cpp Outdated Show resolved Hide resolved
week2/exercise P1008 in LuoGu.cpp Outdated Show resolved Hide resolved
week2/exercise P1008 in LuoGu.cpp Outdated Show resolved Hide resolved
week2/exercise P1008 in LuoGu.cpp Outdated Show resolved Hide resolved
week2/exercise P1008 in LuoGu.cpp Outdated Show resolved Hide resolved
@idear1203
Copy link
Contributor

Nice to remove spaces in the file name

@idear1203
Copy link
Contributor

Try using more meaningful PR title and description. The title should briefly introduce what the PR aims to do while the description should provide more details. Reference here for example.

idear1203
idear1203 reviewed Dec 23, 2019
View reviewed changes
week2/exercise P1008 in LuoGu.cpp Outdated Show resolved Hide resolved
week2/exercise P1008 in LuoGu.cpp Outdated Show resolved Hide resolved
week2/exercise P1008 in LuoGu.cpp Outdated Show resolved Hide resolved
week2/exercise P1008 in LuoGu.cpp Outdated Show resolved Hide resolved
week2/exercise P1008 in LuoGu.cpp Outdated Show resolved Hide resolved
@idear1203
Copy link
Contributor

Familiar yourself with Git commands such as git add, git commit and git push. You will find the magic of Git soon:)

idear1203
idear1203 approved these changes Dec 24, 2019
View reviewed changes
Copy link
Contributor

@idear1203 idear1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@idear1203
Copy link
Contributor

idear1203 commented Dec 24, 2019 •
edited
Loading

Try using more meaningful PR title and description. The title should briefly introduce what the PR aims to do while the description should provide more details. Reference here for example.

@xiaotong-sun xiaotong-sun merged commit 643a72a into master Dec 24, 2019
@xiaotong-sun xiaotong-sun deleted the xiaotong-sun-patch-2 branch February 9, 2020 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idear1203 idear1203 idear1203 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaotong-sun @idear1203