Day field improvements: Fixes #502, Fixes #497 #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
febbraiod
commented
Aug 14, 2018
|
|
||
| if (date < minDate) date = minDate; | ||
| if (date > maxDate) date = maxDate; | ||
|
|
There was a problem hiding this comment.
Debatable if this is the correct incremental step. I could also see just returning to keeping the previous value. My thought here is that one might be entering some arbitrary 'really long time ago' or 'really long time from now' date that is meant to mean 'show me everything'.
Ext actually displays the invalid date in this case but shows an inline validation failure. Which Lee mentioned we are headed toward.
There was a problem hiding this comment.
I agree its debateable what the right things to do is, but we definitely need to do something, and this seems like a good first step.
We can revisit shortly during our validation work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.