Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to ViewManagerModel.selectViewAsync for whether a user sho… #3888

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Add flag to ViewManagerModel.selectViewAsync for whether a user sho… #3888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions cmp/viewmanager/ViewManagerModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,14 +346,19 @@ export class ViewManagerModel<T = PlainObject> extends HoistModel {
}
}

async selectViewAsync(info: ViewInfo): Promise<void> {
async selectViewAsync(info: ViewInfo, opts = {alertUnsavedChanges: true}): Promise<void> {
// ensure any pending auto-save gets completed
if (this.isValueDirty && this.isViewAutoSavable) {
await this.maybeAutoSaveAsync();
}

// if still dirty, require confirm
if (this.isValueDirty && this.view.isOwned && !(await this.confirmDiscardChangesAsync())) {
if (
opts.alertUnsavedChanges &&
this.isValueDirty &&
this.view.isOwned &&
!(await this.confirmDiscardChangesAsync())
) {
return;
}

Expand Down
Loading