Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move logic referencing componentProps out of constructors and into onLinked #3884

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

TomTirapani
Copy link
Member

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@TomTirapani TomTirapani requested a review from lbwexler January 2, 2025 11:19
@lbwexler lbwexler merged commit d363d5d into develop Jan 2, 2025
2 checks passed
@lbwexler lbwexler deleted the componentPropsOnLinked branch January 2, 2025 14:19
@amcclain
Copy link
Member

amcclain commented Jan 2, 2025

Catching up on the recent PRs - just want to ensure I understand this.

Is it the case that the throwIf checks were simply doing nothing before, and the other reactions were working previously, but started throwing when components props initialized to null in #3883 (vs previous {})?

@amcclain
Copy link
Member

amcclain commented Jan 2, 2025

Just saw b484cac which I think answers the second question - thanks, great change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants