Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort ungrouped items at bottom. #3872

Merged
merged 2 commits into from
Dec 26, 2024
Merged

Sort ungrouped items at bottom. #3872

merged 2 commits into from
Dec 26, 2024

Conversation

lbwexler
Copy link
Member

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@lbwexler lbwexler requested a review from ghsolomon December 26, 2024 15:21
@lbwexler lbwexler linked an issue Dec 26, 2024 that may be closed by this pull request
@@ -1771,7 +1771,11 @@ export class GridModel extends HoistModel {
}

defaultGroupSortFn = (a, b) => {
return a < b ? -1 : a > b ? 1 : 0;
// Place ungrouped items at bottom.
if (a == b) return 0;
Copy link
Contributor

@ghsolomon ghsolomon Dec 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe more appropriate to use strict equality checks? (i.e. (0 == '') = true but (0 === '') = false). (Irrelevant if groups are always strings.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@lbwexler lbwexler merged commit 2368d09 into develop Dec 26, 2024
1 check passed
@lbwexler lbwexler deleted the betterGroupSorting branch December 26, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GridModel sort blank groups to bottom
2 participants