-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Mask, ErrorMessage, LoadingIndicator and TreeMap cross-platform #3866
Conversation
Is this completely driven by mask and errorMessage? |
Tom and I discussed this -- Tom is going to take another pass and see if he can make mask and errorMessage cross-platform -- this would be more of a breaking change, but could give us much more bang for the buck, and would make a cross-platform version of this (and maybe other components) trivial. |
+ Make `Mask` cross-platform + Make `LoadingIndicator` cross-platform
Updated this and the toolbox PR to make ErrorMessage and Mask cross-platform, and therefore not require two implementations of TreeMap / SplitMap. Also made LoadingIndicator cross-platform as it was low-hanging fruit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am all for this -- thanks tom!
@amcclain -- are you ok with this somewhat noisy breaking change to imports? I think its worth it. |
If you guys are all good with it, I am too. Have not reviewed this change myself, but I've been bitten a few times with errorMessage not being cross-platform, so am very happy to see a resolution to that and all for it. |
See issue: #3818
See Toolbox PR: xh/toolbox#747
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.
develop
branch as of last change.breaking-change
label + CHANGELOG if so.If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.