Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View manager follow ups #3830

Merged
merged 14 commits into from
Nov 18, 2024
Merged

View manager follow ups #3830

merged 14 commits into from
Nov 18, 2024

Conversation

lbwexler
Copy link
Member

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@lbwexler lbwexler linked an issue Nov 17, 2024 that may be closed by this pull request
Follow-on items on ViewManager release #3829
Closed
14 tasks
@lbwexler
+ Tweak import
189c8b4
@lbwexler
+ Load View Definitions dynamically, when switching to them.
6fb5c8a 
+ Tweak to type of JsonBlobService.
@lbwexler
+ Tweaks to ManageDialogModel grid
2376a5d
@lbwexler
Checkpoint:
e673996 
+ Show dirty save button for "Save As"
+ persist user AutoSave.
+ related cleanups
+ Use 'impl' directory
@lbwexler
Support for Revert Button
80ff574
@lbwexler
Split-apart Autosave and Save handling.
265bd2c 
Do not do full refresh of view for either.
lbwexler and others added 5 commits November 18, 2024 10:40
@lbwexler
Feedback from CR
fa2ab41
@amcclain
Fix closing manage dialog when multi-select active
8534ba8
@amcclain
Don't append (COPY) in save-as dialog
77e6dc0 
+ Validation will ensure that users choose a new unique name before saving.
+ Adding "(COPY)" does not serve any particular instances - a user will need to delete it (extra typing) or will leave it in place, resulting in sub-optimal view names.
@lbwexler
Feedback from CR
2328dd4
@lbwexler
Provisional message for Changelog
a9ff7e7
@lbwexler lbwexler merged commit 2975272 into develop Nov 18, 2024
2 checks passed
@lbwexler lbwexler deleted the viewManagerFollowUps branch November 18, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghsolomon ghsolomon ghsolomon left review comments

@amcclain amcclain Awaiting requested review from amcclain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Follow-on items on ViewManager release
3 participants
@lbwexler @ghsolomon @amcclain