Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for debounced and bulk uploading of track messages #3802

Merged
merged 4 commits into from
Oct 12, 2024
Merged

Conversation

lbwexler
Copy link
Member

@lbwexler lbwexler commented Oct 8, 2024

  • Support for provided timestamp.
  • PrefService cleanups for compatibility

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

+ Support for provided timestamp.
+ PrefService cleanups for compatibility
svc/PrefService.ts Outdated Show resolved Hide resolved
@amcclain
Copy link
Member

amcclain commented Oct 8, 2024

Have to pause looking though here to run to 🤖 club but will complete this evening - eager to get this nice optimization merged in!

@lbwexler lbwexler merged commit 8c1e178 into develop Oct 12, 2024
1 check passed
@lbwexler lbwexler deleted the bulkTrack branch October 12, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batch POSTs for activity tracking calls
2 participants