Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New bindable AppContainerModel.intializingLoadMaskMessage #3763

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

jacob-xhio
Copy link
Contributor

@jacob-xhio jacob-xhio commented Aug 22, 2024

…sages for hoist apps

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@jacob-xhio
Copy link
Contributor Author

Screenshot 2024-08-22 at 11 03 09 AM

Copy link
Member

@amcclain amcclain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks - small comments below, also pls add the same to mobile

appcontainer/AppContainerModel.ts Outdated Show resolved Hide resolved
appcontainer/AppContainerModel.ts Outdated Show resolved Hide resolved
jacob-xhio and others added 2 commits August 22, 2024 12:51
@amcclain amcclain merged commit d2739e2 into develop Aug 22, 2024
1 check passed
@amcclain amcclain deleted the initializingMessage branch August 22, 2024 21:31
@amcclain amcclain changed the title feat(AppContainerModel): expose bindable var to allow custom init mes… New bindable AppContainerModel.intializingLoadMaskMessage Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore option to customize AppContainer load mask message during INITIALIZING state
2 participants