Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultifieldRenderer - supplied renderer is always allowed to transform value #3539

Merged
merged 1 commit into from
Nov 28, 2023
Merged

MultifieldRenderer - supplied renderer is always allowed to transform value #3539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions cmp/grid/renderers/MultiFieldRenderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,10 @@ function renderSubField({colId, label}, context) {

if (label && !isString(label)) label = headerName;

const renderedVal = renderValue(value, renderer, column, context);
const renderedVal = renderValue(value, renderer, column, context),
renderedValIsEmpty = renderedVal === '' || isNil(renderedVal);

return isNil(renderedVal)
return renderedValIsEmpty
? null
: div({
className: 'xh-multifield-renderer-field',
Expand All @@ -118,8 +119,8 @@ function renderSubField({colId, label}, context) {
}

function renderValue(value, renderer, column, context) {
if (isNil(value)) return null;
return renderer ? renderer(value, {...context, column}) : value;
const ret = renderer ? renderer(value, {...context, column}) : value;
return isNil(ret) ? null : ret;
}

function renderDelimiter(delimiter) {
Expand Down
Loading