Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ReactionSpec.equals type to include supported string shorthands #3536

Merged
merged 2 commits into from
Nov 26, 2023

Conversation

jskupsik
Copy link
Contributor

@jskupsik jskupsik commented Nov 24, 2023

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@jskupsik jskupsik requested a review from lbwexler November 24, 2023 23:51
@jskupsik
Copy link
Contributor Author

I noticed that we fully support string shorthands for a couple default mobx comparer types, ie { equals: 'shallow' }, but the ReactionSpec type definition did not help indicate this fact.

ReactionSpec is now a type because the interface+extends declaration resulted in a typescript error. Types and interfaces are very similar - this should not cause any issues.

@lbwexler lbwexler merged commit 8685b79 into develop Nov 26, 2023
2 checks passed
@lbwexler lbwexler deleted the reactionSpecEqualsType branch November 26, 2023 21:20
@lbwexler
Copy link
Member

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants