Add ZoneGrid component #3512
Merged
Add ZoneGrid component #3512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Cleanup headerName extraction
+ Move MultiZoneGrid to mobile
lbwexler
reviewed
Oct 31, 2023
lbwexler
reviewed
Oct 31, 2023
lbwexler
reviewed
Oct 31, 2023
lbwexler
reviewed
Oct 31, 2023
| this.persistenceModel?.clear(); | ||
|
|
||
| if (this.restoreDefaultsFn) { | ||
| await this.restoreDefaultsFn(); |
There was a problem hiding this comment.
use conditional eval on 183 to match line 180?
There was a problem hiding this comment.
I tried that, but IJ complained about it with the await
lbwexler
reviewed
Oct 31, 2023
lbwexler
reviewed
Oct 31, 2023
lbwexler
reviewed
Oct 31, 2023
lbwexler
reviewed
Oct 31, 2023
| }); | ||
|
|
||
| // 2) Ensure mapping respects configured limits | ||
| const limit = this.limits?.[zone]; |
There was a problem hiding this comment.
I wonder about 'constraints' vs. 'limits'
lbwexler
reviewed
Oct 31, 2023
lbwexler
reviewed
Oct 31, 2023
lbwexler
reviewed
Oct 31, 2023
mobile/cmp/multiZoneGrid/Types.ts
Outdated
| /** Max number of fields that should be mapped to the zone */ | ||
| max?: number; | ||
| /** Array of allowed fields for the zone */ | ||
| only?: string[]; |
There was a problem hiding this comment.
Think its a better name, and happy to change, but wanted to point out that this name (and 'limits') were taken from the Sencha API.
lbwexler
reviewed
Oct 31, 2023
lbwexler
reviewed
Oct 31, 2023
lbwexler
reviewed
Oct 31, 2023
…, rather than left / right column + Add sort control to MultiZoneMapper
+ Add desktop ZoneMapper, with corresponding button and context menu action
lbwexler
reviewed
Nov 1, 2023
lbwexler
reviewed
Nov 1, 2023
lbwexler
reviewed
Nov 1, 2023
lbwexler
reviewed
Nov 1, 2023
…t / right column during Store field creation
+ Remove default `restoreDefaultsWarning`
+ Make mobile zone mapper true fullscreen
lbwexler
reviewed
Nov 2, 2023
| onInteraction: (willOpen, e?) => { | ||
| if (isOpen && !willOpen) { | ||
| // Prevent clicks with Select controls from closing popover | ||
| const selectPortal = document.getElementById(MENU_PORTAL_ID), |
There was a problem hiding this comment.
yikes -- this could hit any application. Is there a way we can change select to not leak these?
There was a problem hiding this comment.
Yeah, we have similar patterns in some client apps that would be great to unwind in favour of built-in protection. I'll file a ticket 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Toolbox PR: xh/toolbox#679
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.
developbranch as of last change.breaking-changelabel + CHANGELOG if so.If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.