Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added xh-bg-intent-xxx classNames #3486

Merged
merged 7 commits into from
Dec 12, 2023
Merged

Added xh-bg-intent-xxx classNames #3486

merged 7 commits into from
Dec 12, 2023

Conversation

jskupsik
Copy link
Contributor

@jskupsik jskupsik commented Sep 26, 2023

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@lbwexler lbwexler requested a review from TomTirapani November 17, 2023 11:36
@lbwexler
Copy link
Member

Just noticed that this is a draft, but looks like a promising little cleanup

@jskupsik jskupsik marked this pull request as ready for review November 25, 2023 00:26
@amcclain amcclain changed the title Added the 'xh-bg-intent-' series of classNames, for setting background-color intent Added xh-bg-intent-xxx classNames Dec 12, 2023
@amcclain amcclain merged commit a9502a7 into develop Dec 12, 2023
2 checks passed
@amcclain amcclain deleted the bgIntentStyles branch December 12, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants