Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ErrorMessage with ability to view error details #3482

Merged
merged 5 commits into from
Sep 18, 2023

Conversation

lbwexler
Copy link
Member

Enhanced ability to get details from ErrorMessage.

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@lbwexler
Copy link
Member Author

Pretty repetitive code here between mobile and desktop, all because of the different button types. Not dealing with that in this PR.

desktop/cmp/error/ErrorMessage.ts Outdated Show resolved Hide resolved
desktop/cmp/error/ErrorMessage.ts Show resolved Hide resolved
desktop/cmp/error/ErrorMessage.ts Show resolved Hide resolved
desktop/cmp/error/ErrorMessage.ts Show resolved Hide resolved
mobile/cmp/error/ErrorMessage.ts Show resolved Hide resolved
mobile/cmp/error/ErrorMessage.ts Show resolved Hide resolved
@lbwexler lbwexler merged commit 118839a into develop Sep 18, 2023
@lbwexler lbwexler deleted the enhanceErrorMessage branch September 18, 2023 22:00
@amcclain amcclain changed the title Enhance error message Enhance ErrorMessage with ability to view error details Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants