-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Banners to render basic markdown such as links and emphasis. #3481
Conversation
Thank you for jumping on this - has been on my list for a while to discuss built-in markdown support, and this was a good prompt to do so.
By way of example
|
Another thought - at some point it would be great to have a user-friendly Codemirror has a markdown mode and we could certainly configure that, but then you are in monospace/non-wrapping "code editing" mode and that's not really the experience I think we would want for user (or even admin) facing MD editing. Not something we need to do for this PR, but it could be a companion comp we could consider when we go to use MD more widely for use cases like in-app comments (something I'd like to offer in one of our current apps). |
+ Add `remark-breaks` plugin to convert line-breaks to <br> + Render Markdown in alert banner "Read More" popup + Update CHANGELOG entry
Thanks for taking a look Anselm - I've updated the PR. Including the |
According |
This looks great to me --- we might want to add some text in the banner admin discussing what is going to work, and what won't. Happy to merge this now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting those additional changes in 👍
reactMarkdown
component and dependency.Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.
develop
branch as of last change.breaking-change
label + CHANGELOG if so.If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.