Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to DateInput with enableTextInput: false #3461

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Conversation

amcclain
Copy link
Member

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

+ Ensure calendar picker shows when clicked as intended.
+ Fixes breaking change in Chrome v116
+ Fixes #3460 - see ticket for additional details on the Chrome change.
+ Add className to click handler wrapper div - no functional effect, just wanted to better document why it's there, help clarify when inspecting markup
@amcclain
Copy link
Member Author

Would like to add CL entry but must run right now

@lbwexler lbwexler merged commit b01cf45 into develop Aug 23, 2023
@lbwexler lbwexler deleted the disabledDateInputFix branch August 23, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DateInput with enableTextInput: false no longer shows picker pop-up when clicked
2 participants