-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid with hideHeaders:true
omits extraneous header border
#3435
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking at this - one comment + one question below - let's get it merged in today.
cmp/ag-grid/AgGrid.ts
Outdated
@@ -78,7 +86,8 @@ export const [AgGrid, agGrid] = hoistCmp.withFactory<AgGridProps>({ | |||
stripeRows ? 'xh-ag-grid--stripe-rows' : 'xh-ag-grid--no-stripe-rows', | |||
cellBorders ? 'xh-ag-grid--cell-borders' : 'xh-ag-grid--no-cell-borders', | |||
showCellFocus ? 'xh-ag-grid--show-cell-focus' : 'xh-ag-grid--no-cell-focus', | |||
isDesktop && showHover ? 'xh-ag-grid--show-hover' : 'xh-ag-grid--no-hover' | |||
isDesktop && showHover ? 'xh-ag-grid--show-hover' : 'xh-ag-grid--no-hover', | |||
hideHeaders ? 'xh-grid-header--hidden' : null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like xh-ag-grid--hide-headers
would be a more consistent with the other classnames here. Agreed we don't need a class for the default "not hidden" case.
Thanks - let's look together today - right now this is placing an |
hideHeaders:true
omits extraneous header border
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.
develop
branch as of last change.breaking-change
label + CHANGELOG if so.If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.