Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote supported properties as part of DataViewModel API #3422

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

connor15mcc
Copy link
Contributor

@connor15mcc connor15mcc commented Jul 19, 2023

After re-examining the DataViewModel API, we've made explicit the support for groupSortFn, showGroupRowCounts, and hideEmptyTextBeforeLoad. Our previous "escape hatch" to pass parameters to GridModel did not call attention to the lack of formal support for these properties -- recent changes (#3421) have highlighted this and motivated this corresponding change.

Associated toolbox PR: xh/toolbox#662

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@connor15mcc connor15mcc force-pushed the improved-DataViewModel-api branch from 2c28336 to 38ab332 Compare July 19, 2023 15:50
@connor15mcc connor15mcc requested a review from lbwexler July 19, 2023 15:51
@lbwexler lbwexler merged commit 706fe9a into develop Jul 19, 2023
@lbwexler lbwexler deleted the improved-DataViewModel-api branch July 19, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants