New XH.pageState observable + refactors of XH-based implementation code
#3409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ make XH.clientAppCode backed by observable.
+ make XH.clientAppCode backed by observable.
# Conflicts: # CHANGELOG.md
+ make XH.clientAppCode backed by observable.
+ Mark boolean getters as @computed
# Conflicts: # CHANGELOG.md
cnrudd
reviewed
Jul 3, 2023
lbwexler
commented
Jul 5, 2023
| @@ -156,7 +150,8 @@ export class ExceptionHandler { | |||
| * @param options - provides further control over how the exception is shown and/or logged. | |||
| */ | |||
| showException(exception: unknown, options?: ExceptionHandlerOptions) { | |||
| if (this.#isUnloading) return; | |||
| if (XH.pageState == 'terminated' || XH.pageState == 'frozen') return; | |||
|
Taking a look at this today! |
lbwexler
commented
Jul 5, 2023
lbwexler
commented
Jul 5, 2023
amcclain
changed the title
XH.pageState observable + refactors of XH-based implementation code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.
developbranch as of last change.breaking-changelabel + CHANGELOG if so.If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.