Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new enableTooltipsOnTags prop to Select #3367

Merged
merged 7 commits into from
May 18, 2023
Merged

Conversation

cnrudd
Copy link
Member

@cnrudd cnrudd commented May 16, 2023

…Multi is true.

There is a corresponding Toolbox
PR: xh/toolbox#649
and branch: https://github.com/xh/toolbox/tree/selectTagToolTips

which demo this new prop enableTooltipsOnTags.

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@amcclain amcclain changed the title solves: #3366 - optionally show tooltip on tags in select when enable… Add new enableTooltipsOnTags prop to Select May 17, 2023
Copy link
Member

@amcclain amcclain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I think it's worth it to use the BP tooltips, despite the small amount of extra complexity over (say) using a div with a title attribute. The BP tooltips are nicer and it seems like the required style override is very reasonable and we're not seeing any other negative side effects.

@lbwexler lbwexler merged commit 92bf4e2 into develop May 18, 2023
@lbwexler lbwexler deleted the selectTagToolTips branch May 18, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants