-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grouping chooser commit on change #3361
Conversation
…opover formatting, and recorded CHANGELOG.md
…opover formatting, recorded in CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor tweaks I'd suggest to the comments, but looking good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor tweaks I'd suggest to the comments, but looking good to me!
Co-authored-by: Anselm McClain <[email protected]>
Co-authored-by: Anselm McClain <[email protected]>
@leogretz2 -- I wend ahead and merged this with Anselm's doc comment changes. Please check out those changes -- definitely worth understanding his suggestions and the API docs style we are looking for. |
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.
develop
branch as of last change.breaking-change
label + CHANGELOG if so.If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.