Skip to content

Commit

Permalink
Multifield renderer always lets the supplied value render attempt to …
Browse files Browse the repository at this point in the history
…transform value (#3539)
  • Loading branch information
febbraiod authored Nov 28, 2023
1 parent 66177e4 commit 712e596
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions cmp/grid/renderers/MultiFieldRenderer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,10 @@ function renderSubField({colId, label}, context) {

if (label && !isString(label)) label = headerName;

const renderedVal = renderValue(value, renderer, column, context);
const renderedVal = renderValue(value, renderer, column, context),
renderedValIsEmpty = renderedVal === '' || isNil(renderedVal);

return isNil(renderedVal)
return renderedValIsEmpty
? null
: div({
className: 'xh-multifield-renderer-field',
Expand All @@ -118,8 +119,8 @@ function renderSubField({colId, label}, context) {
}

function renderValue(value, renderer, column, context) {
if (isNil(value)) return null;
return renderer ? renderer(value, {...context, column}) : value;
const ret = renderer ? renderer(value, {...context, column}) : value;
return isNil(ret) ? null : ret;
}

function renderDelimiter(delimiter) {
Expand Down

0 comments on commit 712e596

Please sign in to comment.