Fix ViewManagerModel unique name validation

xh · Jan 16, 2025 · 2d7e67a · 2d7e67a
1 parent b2a95a1
commit 2d7e67a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## v72.0.0-SNAPSHOT - unreleased
 
+### 🐞 Bug Fixes
+
+* Fixed `ViewManagerModel` unique name validation.
+
 ### ⚙️ Technical
 
 * Added support for providing custom `PersistenceProvider` implementations to `PersistOptions`.

diff --git a/cmp/viewmanager/ViewManagerModel.ts b/cmp/viewmanager/ViewManagerModel.ts
@@ -456,7 +456,8 @@ export class ViewManagerModel<T = PlainObject> extends HoistModel {
         if (name.length > maxLength) {
             return `Name cannot be longer than ${maxLength} characters`;
         }
-        if (this.ownedViews.some(view => view.name === name && view.token != existing?.token)) {
+        const views = existing?.isGlobal ? this.globalViews : this.ownedViews;
+        if (views.some(view => view.name === name && view.token != existing?.token)) {
             return `A ${this.typeDisplayName} with name '${name}' already exists.`;
         }
         return null;