Improve EmailService subjects generated for non-prod / overridden deliveries
#378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md
|
Pushed a few additional tweaks + internal typings while reviewing - I read through it and looks like a nice cleanup, but did not run or test myself . @jskupsik if you have a chance over the next day or two, can you please review and test out the expected use cases so we can safely get this in? Many thanks. |
amcclain
changed the title
EmailService subjects generated for non-prod / overridden deliveries
jskupsik
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went way too deep down this rabbit hole -- but there was nothing else to do but finish it