Simplified the xhDbConnectionMonitor query to work with more SQL dialects #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could also potentially do |
|
Not sure why we had that LIMIT 1 in there given that code has a unique constraint - thanks for fixing! |
|
Wish we had just made this configurable via params - found it failing on a deployment, went to adjust the monitor config then remembered this is hard-coded. |
|
I don't feel too bad about that -- I think this is more appropriate than config driven sql would have been |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing query,
SELECT * FROM xh_monitor WHERE code = 'xhDbConnectionMonitor' LIMIT 1, does not work in SQL Server (Microsoft SQL).The equivalent statement in SQL Server would be
SELECT TOP(1) * FROM xh_monitor WHERE code = 'xhDbConnectionMonitor'I propose we simplify it to the SQL statement
SELECT * FROM xh_monitor WHERE code = 'xhDbConnectionMonitor', which should work in all dialects.