Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue in the version #592

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Fix issue in the version #592

merged 1 commit into from
Sep 10, 2024

Conversation

nwlandry
Copy link
Collaborator

This fixes #591.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.14%. Comparing base (112df1c) to head (fe0bd36).
Report is 50 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #592   +/-   ##
=======================================
  Coverage   93.14%   93.14%           
=======================================
  Files          60       60           
  Lines        4506     4506           
=======================================
  Hits         4197     4197           
  Misses        309      309           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maximelucas
Copy link
Collaborator

There's just this url error:
🤔 Uh oh... The following urls did not pass:
❌️ https://cran.r-project.org/package=HyperG

Approving already anyway

@nwlandry
Copy link
Collaborator Author

There's just this url error: 🤔 Uh oh... The following urls did not pass: ❌️ https://cran.r-project.org/package=HyperG

Approving already anyway

Yeah, this is beyond our control, but FWIW, the link works now.

@nwlandry nwlandry merged commit 032f7a2 into main Sep 10, 2024
23 of 24 checks passed
@nwlandry nwlandry deleted the fix-bad-version branch September 10, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not sure exactly what caused this but now the New release button says "dev" instead of the version number:
2 participants