Adds flag for github runs to force all tests to run or error out (#150)

Previously, tests were skipped if config stuff was not properly defined, which masked a lot of errors. This flag, set during the build process, overrides that. --------- Co-authored-by: Hoyt Koepke <[email protected]>
xetdata · Jul 1, 2024 · a146034 · a146034
1 parent d66fc6c
commit a146034
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 0 deletions.
diff --git a/.github/workflows/commit.yml b/.github/workflows/commit.yml
@@ -5,6 +5,7 @@ jobs:
     env:
       AWS_ACCESS_KEY_ID: ${{ secrets.DEV_AWS_ACCESS_KEY }}
       AWS_SECRET_ACCESS_KEY: ${{ secrets.DEV_AWS_SECRET_KEY }}
+      XET_FORCE_ALL_TESTS: 1
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest, macos-latest]

diff --git a/python/pyxet/tests/cli_standalone_cp_tests.py b/python/pyxet/tests/cli_standalone_cp_tests.py
@@ -18,6 +18,9 @@
 
 if xet_cli_path is None:
     print("Warning: XET_STANDALONE_CLI not set, skipping all tests.")
+
+    if os.environ.get("XET_FORCE_ALL_TESTS") == "1":
+        raise ValueError("xet_cli_path is not set.")
 
 def xet_url(branch = None, path = None): 
     ret = f"xet://{host}:{user}/{repo}"
@@ -309,4 +312,14 @@ def test_directory_recursive_upload():
         delete_branch(b1) 
 
 
+from utils import CONSTANTS, require_s3_creds
+
+@pytest.mark.skipif(xet_cli_path is None)
+@require_s3_creds()
+def test_s3_sync(): 
 
+    b1 = utils.new_random_branch_from(f"xet://{host}:{user}/{repo}", "main")
+    xet_url = f"xet://{host}:{user}/{repo}/{b1}/"
+    run_xet("sync", f"s3://{CONSTANTS.S3_BUCKET}/sync1", xet_url)
+
+    utils.assert_remote_files_exist(f"{xet_url}/*", ["js/main.d8604548.js", "tmp-1"])
diff --git a/python/pyxet/tests/utils.py b/python/pyxet/tests/utils.py
@@ -152,6 +152,9 @@ def try_load_s3():
             return False
 
     msg = "AWS credentials not defined"
+    if os.environ.get("XET_FORCE_ALL_TESTS") == "1":
+        return pytest.mark.skipif(False, reason="") # noop
+
     return pytest.mark.skipif(not try_load_s3(), reason=msg)