Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes package and adds some readme notes #560

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Fixes package and adds some readme notes #560

merged 2 commits into from
Nov 24, 2023

Conversation

fedefernandez
Copy link
Contributor

This PR fixes the package name.

It also adds some notes to the README after giving it a try.

BTW, it works great, thanks @javipacheco

javipacheco
javipacheco approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@javipacheco javipacheco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks for the revision

tomascayuelas
tomascayuelas approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@tomascayuelas tomascayuelas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@fedefernandez fedefernandez merged commit 3cd9754 into main Nov 24, 2023
@fedefernandez fedefernandez deleted the fix/evaluator-example branch November 24, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javipacheco javipacheco javipacheco approved these changes

@tomascayuelas tomascayuelas tomascayuelas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fedefernandez @javipacheco @tomascayuelas