Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for break in loop/for/while loops #265

Merged
merged 2 commits into from
Oct 7, 2019

Conversation

camchenry
Copy link
Contributor

@camchenry camchenry commented Oct 7, 2019

This adds some tests for covering the break expression in for, while and loop blocks/expressions (per #54). This is my first contribution to this project, so please let me know what I can change to increase the code quality.

tests/mod.rs Outdated Show resolved Hide resolved
tests/data/breaks/src/lib.rs Outdated Show resolved Hide resolved
@xd009642
Copy link
Owner

xd009642 commented Oct 7, 2019

LGTM! Thanks for the work 👍

@xd009642 xd009642 merged commit 49afaa9 into xd009642:develop Oct 7, 2019
@camchenry camchenry deleted the add-break-tests branch October 11, 2019 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants