Fix include-test
config to include non-std test
#1503
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The original issue is sorta described here: #351 (comment).
But tl;dr version is when
include-tests
is set,#[tokio::test]
is not covered in the coverage report.Changes in this PR:
Added an additional condition to
visit_fn
to check whether thePathSegment
s ends intest
, such as#[tokio::test]
or#[some_fancy_crate::test]
.I tested this tarpaulin version against the issue that I was originally encountering, and it seems to fix it.
Before where
#[tokio::test]
was ignored: https://app.codecov.io/gh/kube-rs/kube/blob/cov-tweak/kube-runtime%2Fsrc%2Fcontroller%2Ffuture_hash_map.rs#L85After where it's now included: https://app.codecov.io/gh/tyrone-wu/kube/blob/main/kube-runtime%2Fsrc%2Fcontroller%2Ffuture_hash_map.rs#L85