-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1523 #1463 #457
Merged
Merged
#1523 #1463 #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ionality with current B/E
…d /api/molgroup with /api/siteobservationgroup, minor fixes
…ties headers from it too
boriskovar-m2ms
approved these changes
Oct 16, 2024
boriskovar-m2ms
added a commit
that referenced
this pull request
Nov 4, 2024
* Squashed commit of the following: commit e613216 Author: Boris Kovar <[email protected]> Date: Wed Jul 31 13:57:02 2024 +0200 - implemented #1251 * #1482 added TagName and CentroidRes columns for expanded view of observation dialog * #1489 show warning toast message if is defined on target load * #1322 added longcode column * updated general function for tag comparison * #1505 adjusted getting of centroid_res * #1458 allow to tag XCA sites, temp commit # Conflicts: # js/components/preview/molecule/observationsDialog.js * #1458 adjusted functionality and styling to proper change tag * #1508 removed TagName column in expanded observation dialog, changed order of columns, adjusted labels and tooltips, show observation dialog in its full height * #1508 adjusted column order and width calculation * #1501 added upload links to menu * #1501 (#451) * Squashed commit of the following: commit e613216 Author: Boris Kovar <[email protected]> Date: Wed Jul 31 13:57:02 2024 +0200 - implemented #1251 * #1482 added TagName and CentroidRes columns for expanded view of observation dialog * #1489 show warning toast message if is defined on target load * #1322 added longcode column * updated general function for tag comparison * #1505 adjusted getting of centroid_res * #1458 allow to tag XCA sites, temp commit # Conflicts: # js/components/preview/molecule/observationsDialog.js * #1458 adjusted functionality and styling to proper change tag * #1508 removed TagName column in expanded observation dialog, changed order of columns, adjusted labels and tooltips, show observation dialog in its full height * #1508 adjusted column order and width calculation * #1501 added upload links to menu --------- Co-authored-by: Boris Kovar <[email protected]> * #1520 show tag alias instead of upload_name on hit navigator CanonSites & ConformerSites box tooltip * #1519 keep tag in edit window after save * #1519 and #1520 (#453) * Squashed commit of the following: commit e613216 Author: Boris Kovar <[email protected]> Date: Wed Jul 31 13:57:02 2024 +0200 - implemented #1251 * #1482 added TagName and CentroidRes columns for expanded view of observation dialog * #1489 show warning toast message if is defined on target load * #1322 added longcode column * updated general function for tag comparison * #1505 adjusted getting of centroid_res * #1458 allow to tag XCA sites, temp commit # Conflicts: # js/components/preview/molecule/observationsDialog.js * #1458 adjusted functionality and styling to proper change tag * #1508 removed TagName column in expanded observation dialog, changed order of columns, adjusted labels and tooltips, show observation dialog in its full height * #1508 adjusted column order and width calculation * #1501 added upload links to menu * #1520 show tag alias instead of upload_name on hit navigator CanonSites & ConformerSites box tooltip * #1519 keep tag in edit window after save --------- Co-authored-by: Boris Kovar <[email protected]> * #1497 added Path column for extended view of observations * #1497 (#454) * Squashed commit of the following: commit e613216 Author: Boris Kovar <[email protected]> Date: Wed Jul 31 13:57:02 2024 +0200 - implemented #1251 * #1482 added TagName and CentroidRes columns for expanded view of observation dialog * #1489 show warning toast message if is defined on target load * #1322 added longcode column * updated general function for tag comparison * #1505 adjusted getting of centroid_res * #1458 allow to tag XCA sites, temp commit # Conflicts: # js/components/preview/molecule/observationsDialog.js * #1458 adjusted functionality and styling to proper change tag * #1508 removed TagName column in expanded observation dialog, changed order of columns, adjusted labels and tooltips, show observation dialog in its full height * #1508 adjusted column order and width calculation * #1501 added upload links to menu * #1520 show tag alias instead of upload_name on hit navigator CanonSites & ConformerSites box tooltip * #1519 keep tag in edit window after save * #1497 added Path column for extended view of observations --------- Co-authored-by: Boris Kovar <[email protected]> * #1518 properly remove tag from list after updating its object * #1522 allow to change XCA tags for selections but not for CanonSite * #1463 initial implementation of new sort options for hit navigator * #1514 (#456) * #1514 replaced project_id occurrences with project and adjusted functionality with current B/E * #1514 added target_access_string to /api/download_structures, replaced /api/molgroup with /api/siteobservationgroup, minor fixes * #1523 #1463 (#457) * #1514 replaced project_id occurrences with project and adjusted functionality with current B/E * #1514 added target_access_string to /api/download_structures, replaced /api/molgroup with /api/siteobservationgroup, minor fixes * #1523 adjusted inspiration dialog layout and removed molecular properties headers from it too * #1463 show "Ascending" instead of "ASC" when there is a possible space for it * removed unnecessary setter and comments --------- Co-authored-by: Boris Kovar <[email protected]> Co-authored-by: matej <[email protected]> Co-authored-by: matej <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.