Concurrent Scraper Updgrade #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will now no longer wait for the entire wait group to finish before adding more workers. It will add them one when below the concurrent scraper count
Switch to using a function to retrive the count instead of direct access. Something this low level probably should be protected.
crwxaj
pushed a commit
to crwxaj/xbvr
that referenced
this pull request
Aug 28, 2024
This reverts commit d648c4c.
crwxaj
added a commit
that referenced
this pull request
Aug 28, 2024
crwxaj
pushed a commit
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will no longer wait for the entire wait group to finish before adding more workers. It will add one when below the concurrent scraper count. This increases speed by about 20%. Tested twice so far no bugs apparent