-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: new changelog #141
docs: new changelog #141
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
==========================================
+ Coverage 94.21% 94.31% +0.09%
==========================================
Files 71 73 +2
Lines 5823 6083 +260
==========================================
+ Hits 5486 5737 +251
- Misses 337 346 +9 ☔ View full report in Codecov by Sentry. |
that looks really nice, I'll take a look and will play around with it to see whether we can make it work with Github Actions. PS: sorry got confused about the different PRs and deleted the |
Just needed to |
Sorry for the late reply - I’ve been playing around with the
One thing that’s still bugging me is how release messages like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks great to me @nicrie. Feel free to push up your changes. I found and noted the one tweak we need to skip the release commits getting included.
Co-authored-by: Sam Levang <[email protected]>
Co-authored-by: Sam Levang <[email protected]>
{ message = "^revert", group = "<!-- 07 -->:rewind: Revert" }, | ||
{ message = "^test", group = "<!-- 08 -->:microscope: Tests" }, | ||
{ message = "^chore\\(release\\):", skip = true }, | ||
{ message = "^chore|ci|build", group = "<!-- 09 -->:gear: Miscellaneous" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems that we need this pattern here to ignore the release commits
EDIT: sry somehow my vscode got confused - I meant to replace "^chore\\(release\\):"
with "^chore: release"
Looks good to me! |
Fantastic, thanks @slevang for the initiative - I wait for the CI and then I'll hit the button. |
In the past, we used two different styles of release commits. PR #141 did only cover one style. Here we add the second style.
Bullet 2/3 on #126. I tried out a few changelog generators and liked this one best. PR is a WIP because I don't know how to make the GH Actions actually play together. As the release job is written here the changelog is generated but lost.
You can install
git-cliff
locally and run withgit cliff -o CHANGELOG.md
. Lots of configurable options and we could probably use more filtering, but what I currently have looks like this (for example):