tests: move xfail out of functions #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathause
commented
Sep 29, 2023
dcherian
reviewed
Oct 2, 2023
| @pytest.fixture(scope="module", params=["flox", "numpy", "numba"]) | ||
|
|
||
| @pytest.fixture( | ||
| scope="module", params=["flox", "numpy", pytest.param("numba", marks=requires_numba)] |
dcherian
reviewed
Oct 2, 2023
| def raise_if_dask_computes(max_computes=0): | ||
| # return a dummy context manager so that this can be used for non-dask objects | ||
| if not has_dask: | ||
| return dummy_context() | ||
| return nullcontext() |
dcherian
reviewed
Oct 2, 2023
for more information, see https://pre-commit.ci
|
This is great. Thank you! |
dcherian
added a commit
that referenced
this pull request
Oct 2, 2023
* upstream/main: tests: move xfail out of functions (#265)
dcherian
added a commit
to mathause/flox
that referenced
this pull request
Oct 7, 2023
* upstream/main: Support quantile, median, mode with method="blockwise". (xarray-contrib#269) Add multidimensional binning demo (xarray-contrib#203) [pre-commit.ci] pre-commit autoupdate (xarray-contrib#268) Drop python 3.8, test python 3.11 (xarray-contrib#209) tests: move xfail out of functions (xarray-contrib#265) Bump actions/checkout from 3 to 4 (xarray-contrib#267)
dcherian
added a commit
that referenced
this pull request
Nov 3, 2023
* main: (24 commits) Add `packaging` as dependency use engine flox for ordered groups (#266) Update pyproject.toml: py3.12 Bump numpy to >=1.22 (#278) Cleanups (#276) benchmarks updates (#273) repo-review comments (#270) Significantly faster cohorts detection. (#272) Add engine="numbagg" (#72) Support quantile, median, mode with method="blockwise". (#269) Add multidimensional binning demo (#203) [pre-commit.ci] pre-commit autoupdate (#268) Drop python 3.8, test python 3.11 (#209) tests: move xfail out of functions (#265) Bump actions/checkout from 3 to 4 (#267) convert datetime: micro-optimizations (#261) compatibility with `numpy>=2.0` (#257) replace the deprecated `provision-with-micromamba` with `setup-micromamba` (#258) Fix some typing errors in asv_bench and tests (#253) [pre-commit.ci] pre-commit autoupdate (#250) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a look at the flox tests and moved the xfails out of the function body. This is marginally faster as the skipping happens at collection time.
(It's is certainly not worth it but I couldn't sleep..., let me know if any of them look too ugly)