Try cleaning up some expected_groups logic #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
force-pushed
the
cleanup-expected-groups
branch
from
bf3d942 to
6d8f209
Compare
dcherian
commented
Nov 27, 2022
| group_chunks: tuple[tuple[Union[int, float], ...]] = ( | ||
| (len(expected_groups),) if expected_groups is not None else (np.nan,), | ||
| ) | ||
| group_chunks: tuple[tuple[Union[int, float], ...]] |
There was a problem hiding this comment.
@Illviljan the only float value that is valid here is np.nan. Is there a way to narrow this to just np.nan? A simple Literal[np.nan] does not work.
There was a problem hiding this comment.
yeah, I am sad about that as well. :(
Thought a little about this in dask/dask#9255 but came to the conclusion that adding float with a reminder comment was the most practical solution. Here's a relevant typing thread: python/typing#1160
There was a problem hiding this comment.
ah too bad. Thanks!
dcherian
added a commit
to Illviljan/flox
that referenced
this pull request
Nov 27, 2022
* main: Try cleaning up some expected_groups logic (xarray-contrib#175) Update visualizations & docs (xarray-contrib#189) Avoid broadcasting by variables against each other (xarray-contrib#186) Some typing (xarray-contrib#190)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.