Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preserve dtype of by #187

Closed
dcherian opened this issue Nov 5, 2022 · 0 comments
Closed

preserve dtype of by #187

dcherian opened this issue Nov 5, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@dcherian
Copy link
Collaborator

dcherian commented Nov 5, 2022

Seen in #151

Since we use pd.Index internally for expected_groups, everything is promoted to 64-bit types.

We should not do this and restore dtypes before returning the result.

One complication is to handle binning properly, as well as the possibility that corresponding entries in by and expected_groups entries have different dtypes.
@dcherian dcherian added the bug Something isn't working label Nov 28, 2022
dcherian added a commit that referenced this issue Apr 21, 2023
@dcherian
Fix dtype test
6d9161e 
Closes #187
dcherian added a commit that referenced this issue Apr 21, 2023
@dcherian
Preserve input dtypes now that pandas can do it.
28d7105 
Closes #187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dcherian