Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kvikio backend entrypoint #10
Add Kvikio backend entrypoint #10
Changes from 13 commits
9deadb7
aa2dc91
7fb4b94
743fe7d
5d501e4
facf5f7
f3f5189
9c98d19
dd8bc57
d2da1e4
b87c3c2
87cb74e
d7394ef
1b23fef
ca0cf45
97260d6
5d27b26
85491d7
c470b97
95efa18
d684dad
ae2a7f1
15fbafd
f3df115
4e1857a
7345b61
e2b410e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can refactor this to use
kvikio.zarr.open_cupy_array
once kvikio=23.10 is out? There's support for nvCOMP-based LZ4 compression now (that's compatible with Zarr's CPU-based LZ4 compressor), xref rapidsai/kvikio#267.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR welcome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debating on whether to start from scratch in a completely new branch, or rebase off of this one 😄
P.S. I'm starting some work over at https://github.com/weiji14/foss4g2023oceania for a conference talk on 18 Oct, hoping to get the
kvikIO
engine running on an ERA5 dataset. Somehow, I could only get things on this branch to work up tokvikIO==23.06
, it seems like RAPIDS AI 23.08 moved to CUDA 12 and I've been getting some errors likeRuntimeError: Unable to open file: Too many open files
. I'll try to push some code in the next 2 weeks, and should be able to nudge this forward a little bit 😉There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just build on top of this branch in a new PR.
The optimization i was mentioning to save
self.datastore.zarr_group[self.variable_name]
asself._array
. Otherwise we keep pinging the store unnecessarilyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I got a bit too ambitious trying to work in support for LZ4 compression (via nvCOMP), and hit into some issues (see rapidsai/kvikio#297). There's some stable releases of RAPIDS AI kvikIO 23.10.00 and xarray 2023.10.0 now which should have some nice enhancements for this PR. I'll try to squeeze out some time to work on it.