Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getitem support for standard_name #39

Merged
merged 3 commits into from
Jun 23, 2020

Conversation

dcherian
Copy link
Contributor

Closes #37
Closes #4

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2020

Codecov Report

Merging #39 into master will increase coverage by 1.50%.
The diff coverage is 98.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   89.84%   91.35%   +1.50%     
==========================================
  Files           6        7       +1     
  Lines         384      474      +90     
==========================================
+ Hits          345      433      +88     
- Misses         39       41       +2     
Flag Coverage Δ
#unittests 91.35% <98.37%> (+1.50%) ⬆️
Impacted Files Coverage Δ
cf_xarray/accessor.py 93.43% <97.61%> (+1.16%) ⬆️
cf_xarray/tests/datasets.py 100.00% <100.00%> (ø)
cf_xarray/tests/test_accessor.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34384de...a742dfe. Read the comment docs.

@dcherian dcherian merged commit d454cb4 into xarray-contrib:master Jun 23, 2020
@dcherian dcherian deleted the standard-name branch June 23, 2020 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should __getitem__ allow access to normal variable names? Add __getitem__
2 participants