Use standard_name mapper in rename_like #165
Conversation
| @@ -214,8 +214,10 @@ def test_getitem_ancillary_variables(): | |||
| def test_rename_like(): | |||
| original = popds.copy(deep=True) | |||
|
|
|||
| with pytest.raises(KeyError): | |||
| popds.cf.rename_like(airds) | |||
| # it'll match for axis: X (lon, nlon) and coordinate="longitude" (lon, TLONG) | |||
There was a problem hiding this comment.
We used to only check "coordinates", now we check all keys...
| @@ -1312,18 +1310,21 @@ def rename_like( | |||
| ourkeys = self.keys() | |||
| theirkeys = other.cf.keys() | |||
|
|
|||
| good_keys = set(_COORD_NAMES) & ourkeys & theirkeys | |||
There was a problem hiding this comment.
Should we still raise an error?
| popds.cf.rename_like(airds) | ||
| # it'll match for axis: X (lon, nlon) and coordinate="longitude" (lon, TLONG) | ||
| # so delete the axis attributes | ||
| newair = airds.copy(deep=True) |
There was a problem hiding this comment.
would switching to fixtures for the datasets get around this?
| theirs = apply_mapper( | ||
| (_get_axis_coord, _get_with_standard_name), other, key, error=False | ||
| ) | ||
| if len(ours) > 1 or len(theirs) > 1: |
There was a problem hiding this comment.
Could optionally raise a warning here if verbose=True
There was a problem hiding this comment.
Maybe warn ant the end about all other.variables missing in renamer.values()?
There was a problem hiding this comment.
This might work out with staggered grids: Rename axes first, if len(ours)>1 or len(theirs)>1 and all variables in ours and theirs have different combinations of dimensions we should be able to rename. As we already renamed the dimensions, we just have to look at their dims.
Closes #134