ci: detect if there are packages with multiple versions #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindig
reviewed
Dec 1, 2020
lindig
approved these changes
Dec 1, 2020
psafont
force-pushed
the
sanity
branch
2 times, most recently
from
66d5d43 to
07efe5f
Compare
psafont
commented
Dec 1, 2020
| versions=$(echo "$the_versions" | wc -w) | ||
| # the compiler is allowed to have more than one version because it's a | ||
| # separate rpm. xenctrl has 2 versions: dummy and master | ||
| if [ "$versions" -gt 1 ] && echo "$pkg" | grep -vqE '^ocaml$|^ocaml-base-compiler$|^ocaml-system$|^xenctrl$' ; then |
There was a problem hiding this comment.
Changed to match only 4 exact patterns.
There was a problem hiding this comment.
How about the ppxlib? I think that needs 2 versions. One for 4.08 and one for 4.10, or does the latest version work with both?
There was a problem hiding this comment.
We used to have to versions of the ppx_tools_versiones for 4.06 and 4.08.
With the current ppx ecosystem I don't think we need to have 2 version of any library to support two versions.
I think Ppxlib abstracts over the differences in the ASTs exposed through ocaml-migrate-parsetrees. We cannot use the latest versions of ppxlib or O-M-P because bisect_ppx (PR) and shared-block-ring (unmaintaned) haven't been migrated yet.
lippirk
reviewed
Dec 8, 2020
Early detection for a situation that causes problems when building the rpm for the whole repository. Signed-off-by: Pau Ruiz Safont <[email protected]>
lippirk
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoid situations like the last merge which broke building the rpm package for xs-opam.