Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Update to dot releases of AndroidX to fix bundling #10975

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Update to dot releases of AndroidX to fix bundling #10975

merged 1 commit into from
Jun 10, 2020

Conversation

PureWeen
Copy link
Contributor

@PureWeen PureWeen commented Jun 5, 2020 •
edited
Loading

Description of Change

This updates our AndroidX nugets to include the fix for this
dotnet/android-libraries#64

We'll need to wait until the nugets are officially out before we can merge this

Issues Resolved

Platforms Affected

  • Android

Testing Procedure

Follow the steps in this issue
dotnet/android-libraries#64

But use the nuget produced from this PR

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@PureWeen PureWeen added DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. labels Jun 5, 2020
@PureWeen PureWeen requested a review from moljac June 5, 2020 21:56
@PureWeen PureWeen force-pushed the androidx_bundle_fixes branch from 2373671 to d22f1c8 Compare June 8, 2020 17:58
@PureWeen PureWeen removed the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Jun 8, 2020
@samhouts samhouts requested review from hartez and jsuarezruiz June 8, 2020 20:31
@PureWeen PureWeen mentioned this pull request Jun 8, 2020
Closed
@PureWeen PureWeen assigned rmarinho and unassigned jsuarezruiz Jun 8, 2020
@PureWeen PureWeen requested review from rmarinho and removed request for jsuarezruiz June 8, 2020 23:49
@PureWeen PureWeen added the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Jun 8, 2020
@samhouts samhouts added 4.6.0 regression on 4.6.0 Android10 i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often i/regression t/bug 🐛 labels Jun 9, 2020
@moljac
Copy link
Member

moljac commented Jun 9, 2020

AndroidX nugets are pushed. 3-4 users reporting positive feedback.

@PureWeen PureWeen removed the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Jun 9, 2020
@PureWeen PureWeen force-pushed the androidx_bundle_fixes branch from aaf8b90 to 56cdc32 Compare June 9, 2020 14:14
@samhouts samhouts merged commit 97b53d8 into 4.6.0 Jun 10, 2020
@samhouts samhouts deleted the androidx_bundle_fixes branch June 10, 2020 18:34
@samhouts samhouts added this to the 4.6.0 milestone Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moljac moljac moljac approved these changes

@hartez hartez Awaiting requested review from hartez

@rmarinho rmarinho Awaiting requested review from rmarinho

Assignees

@hartez hartez

@rmarinho rmarinho

Labels
4.6.0 regression on 4.6.0 a/visual Android10 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. ControlGallery i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often i/regression p/Android t/bug 🐛
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.
6 participants
@PureWeen @moljac @hartez @rmarinho @jsuarezruiz @samhouts