Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

Check for null MainView on UWP #803

Merged
merged 2 commits into from
May 31, 2019
Merged

Check for null MainView on UWP #803

merged 2 commits into from
May 31, 2019

Conversation

jamesmontemagno
Copy link
Collaborator

Description of Change

Additional null checks on main window if called at the start of an app.

Bugs Fixed

Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.

API Changes

List all API changes here (or just put None), example:

Added:

  • string Class.Property { get; set; }
  • void Class.Method();

Changed:

  • object Cell.OldPropertyName => object Cell.NewPropertyName

If there is an entirely new API, then you can use a more verbose style:

public static class NewClass {
    public static int SomeProperty { get; set; }
    public static void SomeMethod(string value);
}

Behavioral Changes

Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

@jamesmontemagno jamesmontemagno added the awaiting-review This PR needs to have a set of eyes on it label May 30, 2019
@jamesmontemagno jamesmontemagno added this to the 1.1.1 milestone May 30, 2019
@ghost
Copy link

ghost commented May 30, 2019

Docs Build status updates of commit 459ec7b:

✅ Validation status: passed

File Status Preview URL Details
Xamarin.Essentials/MainThread/MainThread.uwp.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@ghost
Copy link

ghost commented May 31, 2019

Docs Build status updates of commit 06f4e59:

✅ Validation status: passed

File Status Preview URL Details
Xamarin.Essentials/MainThread/MainThread.uwp.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Copy link
Contributor

@newky2k newky2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review, build and tested

@newky2k newky2k added ready-to-merge Review completed, Ready for API review and merge and removed awaiting-review This PR needs to have a set of eyes on it labels May 31, 2019
@jamesmontemagno jamesmontemagno merged commit c7ba9d4 into master May 31, 2019
@jamesmontemagno jamesmontemagno deleted the dev/windows-null branch May 31, 2019 17:24
@jamesmontemagno jamesmontemagno modified the milestones: 1.1.1, 1.2.0 Jun 18, 2019
Mrnikbobjeff pushed a commit to Mrnikbobjeff/Essentials that referenced this pull request Aug 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready-to-merge Review completed, Ready for API review and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants