This repository has been archived by the owner on May 15, 2024. It is now read-only.
GH-582 & GH-575: Updated the sensors to adhere to guidelines #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- enum names - compas low pass filter is now a param - updated docs - public constructors on data and events - stating an already started sensor will throw - sensor use the same units on all platforms Added a unit conversion API. #575
This comment has been minimized.
This comment has been minimized.
mattleibow
commented
Nov 5, 2018
| @@ -29,7 +29,7 @@ void Barometer_ReadingChanged(object sender, BarometerChangedEventArgs e) | |||
|
|
|||
| var d = await tcs.Task; | |||
|
|
|||
| Assert.True(d.Pressure >= 0); | |||
| Assert.True(d.PressureInHectopascals >= 0); | |||
There was a problem hiding this comment.
Renamed the property
mattleibow
commented
Nov 5, 2018
| "User Interface" | ||
| }; | ||
| public string[] Speeds { get; } = | ||
| Enum.GetNames(typeof(SensorSpeed)); |
There was a problem hiding this comment.
Using the fancy Enum.GetNames
mattleibow
commented
Nov 5, 2018
| [InlineData(1000, 17.4533)] | ||
| [InlineData(57295.7795, 1000)] | ||
| [InlineData(0, 0)] | ||
| public void DegreesPerSecondToRadiansPerSecond(double degrees, double radians) |
There was a problem hiding this comment.
Tests, baby, tests!
mattleibow
commented
Nov 5, 2018
| @@ -17,10 +17,10 @@ public static void Start(SensorSpeed sensorSpeed) | |||
| throw new FeatureNotSupportedException(); | |||
|
|
|||
| if (IsMonitoring) | |||
| return; | |||
| throw new InvalidOperationException("Accelerometer has already been started."); | |||
There was a problem hiding this comment.
Throw when the sensor is started.
mattleibow
commented
Nov 5, 2018
| @@ -68,19 +68,19 @@ internal static void OnChanged(AccelerometerChangedEventArgs e) | |||
|
|
|||
| public class AccelerometerChangedEventArgs : EventArgs | |||
| { | |||
| internal AccelerometerChangedEventArgs(AccelerometerData reading) => Reading = reading; | |||
| public AccelerometerChangedEventArgs(AccelerometerData reading) => Reading = reading; | |||
There was a problem hiding this comment.
events are public
mattleibow
commented
Nov 5, 2018
|
|
||
| public AccelerometerData Reading { get; } | ||
| } | ||
|
|
||
| public readonly struct AccelerometerData : IEquatable<AccelerometerData> | ||
| { | ||
| internal AccelerometerData(double x, double y, double z) | ||
| public AccelerometerData(double x, double y, double z) |
mattleibow
commented
Nov 5, 2018
| return UnitConverters.CoordinatesToMiles(latitudeStart, longitudeStart, latitudeEnd, longitudeEnd); | ||
| default: | ||
| throw new ArgumentOutOfRangeException(nameof(units)); | ||
| } |
There was a problem hiding this comment.
Moved the conversion logic into the unit conversions API so we can be cool!
mattleibow
commented
Nov 5, 2018
| Default = 0, | ||
| UI = 1, | ||
| Game = 2, | ||
| Fastest = 3, |
There was a problem hiding this comment.
Re ordered enums and renamed values
mattleibow
commented
Nov 5, 2018
| const double milesToKilometers = 1.609344; | ||
| const double milesToMeters = 1609.344; | ||
| const double kilometersToMiles = 1.0 / milesToKilometers; | ||
| const double celsiusToKelvin = 273.15; |
There was a problem hiding this comment.
constants, baby, constants!
jamesmontemagno
approved these changes
Nov 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the sensors to adhere to guidelines:
Added a unit conversion API