-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compact-mode #731
Add compact-mode #731
Conversation
I also think you should update the docs in vp-docs |
I've updated vp-docs too. |
hmm, where is the project maintainer? is this repository still alive? |
It kinda is. But I've also have been Waiting for a review for a couple of months now |
a couple of months for a review! |
I would recommend to package it your self until merged. That's what I'm doing. Added my fork URL to the package.json. but I'm just running an open source hobby project. If you have like nexus. Just publish it your self. |
@alirezanet @p0psicles thank you for your patience! This is now released as new minor version. |
thanks. |
Not sure if I'm missing something, but compactMode doesn't appear to be working/activating in my app or on the documentation page: |
@pixeldemon9 In the documentations you are right, it is not showing compact-mode example, I think documentation is not using the latest version of the component. but if you are using the latest version of VGT on your application you should see the compacted grid in small screens like mobiles (it will be trigger in under 576px screens) |
@alirezanet Discovered I was passing the prop as "compactMode" when it needed to be "compact-mode". Silly mistake on my part, although I think this is how it is presented in the documentation as well. Thanks for this PR, I think this is an important option to handle tables on mobile. |
The table-column slot does not work in compactMode. |
Ture. this is a design choice because usually we don't need that slot in compactMode, |
Nothing critical. I had to translate the column labels based on the locale but I can also achieve that when setting the columns objects. |
We had a lot of problems with VGT on mobile devices. so I decided to add a mobile-friendly feature to VGT.
Normal Mode:

Compact Mode:
please approve pull-request if you like it.