Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compact-mode #731

Merged
merged 24 commits into from
Jul 22, 2020
Merged

Add compact-mode #731

merged 24 commits into from
Jul 22, 2020

Conversation

alirezanet
Copy link
Contributor

@alirezanet alirezanet commented Jul 11, 2020

We had a lot of problems with VGT on mobile devices. so I decided to add a mobile-friendly feature to VGT.

1


Normal Mode:
image


Compact Mode:

2

please approve pull-request if you like it.

@p0psicles
Copy link
Collaborator

I also think you should update the docs in vp-docs

@alirezanet
Copy link
Contributor Author

I also think you should update the docs in vp-docs

I've updated vp-docs too.

@alirezanet alirezanet changed the title Added compact-mode Add compact-mode Jul 12, 2020
@alirezanet
Copy link
Contributor Author

hmm, where is the project maintainer? is this repository still alive?
@xaksis

@p0psicles
Copy link
Collaborator

It kinda is. But I've also have been Waiting for a review for a couple of months now

@alirezanet
Copy link
Contributor Author

a couple of months for a review!
I need this feature in production. today I had to remove VGT and use my own custom one, Although this is not a good idea. what should we do?

@p0psicles
Copy link
Collaborator

I would recommend to package it your self until merged. That's what I'm doing. Added my fork URL to the package.json. but I'm just running an open source hobby project.

If you have like nexus. Just publish it your self.

@xaksis xaksis merged commit 329ed72 into xaksis:master Jul 22, 2020
@xaksis
Copy link
Owner

xaksis commented Jul 22, 2020

@alirezanet @p0psicles thank you for your patience! This is now released as new minor version.

@alirezanet
Copy link
Contributor Author

thanks.

@pixeldemon9
Copy link

Not sure if I'm missing something, but compactMode doesn't appear to be working/activating in my app or on the documentation page:
Docs

@alirezanet
Copy link
Contributor Author

alirezanet commented Aug 17, 2020

@pixeldemon9 In the documentations you are right, it is not showing compact-mode example, I think documentation is not using the latest version of the component. but if you are using the latest version of VGT on your application you should see the compacted grid in small screens like mobiles (it will be trigger in under 576px screens)

@pixeldemon9
Copy link

@alirezanet Discovered I was passing the prop as "compactMode" when it needed to be "compact-mode". Silly mistake on my part, although I think this is how it is presented in the documentation as well.

Thanks for this PR, I think this is an important option to handle tables on mobile.

@dashty94
Copy link

The table-column slot does not work in compactMode.

@alirezanet
Copy link
Contributor Author

The table-column slot does not work in compactMode.

Ture. this is a design choice because usually we don't need that slot in compactMode,
what is your expected behavior ? (because there is not enough space in grid header in compact mode)

@dashty94
Copy link

The table-column slot does not work in compactMode.

Ture. this is a design choice because usually we don't need that slot in compactMode,

what is your expected behavior ? (because there is not enough space in grid header in compact mode)

Nothing critical. I had to translate the column labels based on the locale but I can also achieve that when setting the columns objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants