-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add multiselect filter #587
Feature/add multiselect filter #587
Conversation
This is sweeet! @cassmbautista my only concern is adding another library for something that is not core to the table and might not be used by everyone. |
@xaksis Yea I was concerned about that too since I noticed you have very little dependencies. However, I have no idea how to add it as a plugin for vue-good-table. Any ideas? Do you have any examples of plugins to components? |
Good point. I was actually thinking of making a column-manager plugin for VGT myself to figure out how that'd work. Mind if I hold off on this for a bit? Then we can use that as a template if it works. |
Yea, you can hold off on this for a while. I am also interested in the functionality of the column-manager plugin. |
@xaksis My original mockup: The default sort allows the user to pick which column to sort by by default. |
haha @TheJaredWilcurt that's pretty much exactly what I have implemented in the project that I was planning to refactor. Glad to see it validated! |
Guys (@cassmbautista, @xaksis) while you are discussing the column plugin, it can be a good idea to give an autocomplete function in the filter (let say you want to filter by a particular user, and there are 1000s of the user and autocomplete server fetching is a good option) for those using remote mode |
@bhargavjoshi |
I was thinking about giving users the ability to use their own filter component. Right now we have these options.
We can add a property for a component like this
We have to think about how we can pass data to the component and also get data from the component. My use case Is I want to give two text inputs with labels to put min amount and max amount. (basically a range filter). Let's discuss more on this. |
Nice work! Would love to see this get integrated! |
@xaksis Have you been able to make an example plugin for vue-good-table, so that I can convert this PR to a plugin? |
@cassmbautista really sorry but I have been very busy with another project. When I get a breather I'll get on it! I will keep you updated. |
It's looking good. Can't wait to see it integrated or as a plugin :) |
Hi @xaksis ! Thanks anyhow ! |
src/components/VgtFilterRow.vue
Outdated
return column; | ||
}) | ||
.filter(this.isMultiselectDropdown) | ||
.map(column => column.ref); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can probably be a filter > map
instead of map > filter > map
Added feature #405
This new feature is to add a multiple selection option to vue-good table. Seen in the image below:
The changes made in this PR are: