Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [bugfix] config parameters shouldn't be overriden by 'None' values #69

Merged
merged 1 commit into from
Jan 7, 2023

Conversation

xaf
Copy link
Owner

@xaf xaf commented Jan 7, 2023

This would allow to reach situations with weird bugs as we could go around the _SENTINEL object by setting a value to None, which wouldn't be validated during the config check step.

@github-actions

This comment has been minimized.

@xaf xaf force-pushed the xaf/fix_config_parameter_override_by_none branch from fb5afa5 to a73559a Compare January 7, 2023 18:00
@github-actions

This comment has been minimized.

@xaf xaf force-pushed the xaf/fix_config_parameter_override_by_none branch from a73559a to c798e70 Compare January 7, 2023 18:06
@github-actions
Copy link

github-actions bot commented Jan 7, 2023

Coverage

Coverage Report
FileStmtsMissCoverMissing
apps/qolsysgw
   gateway.py1583180%95–96, 131–154, 162, 187–188, 216–217, 226–227, 236–237, 243, 263–264
apps/qolsysgw/mqtt
   exceptions.py170100% 
   listener.py53885%42–44, 68–70, 74–75
   updater.py241996%192, 195, 265, 328, 389, 394, 472, 513, 561
   utils.py200100% 
apps/qolsysgw/qolsys
   actions.py50296%24, 34
   config.py651282%61–62, 64, 68, 73, 88–100, 110, 139
   control.py151795%39, 47, 51, 58, 65, 81, 88
   events.py2322191%64, 69, 100, 104, 130–131, 163, 167, 190, 201, 208, 235, 251, 265, 278–280, 325, 357, 369, 414
   exceptions.py290100% 
   observable.py17382%13, 17–18
   partition.py120794%149–153, 159–163, 166
   sensors.py1792288%51–72, 116, 120, 126, 155, 159, 166, 183, 187
   socket.py931980%36, 43, 52–54, 83–84, 103–105, 109–110, 114–116, 126–127, 133–134
   state.py64395%24, 74, 82
   utils.py32488%10, 13, 19–20
TOTAL152114890% 

Tests Skipped Failures Errors Time
111 0 💤 0 ❌ 0 🔥 29.165s ⏱️

@xaf xaf merged commit 5813b61 into main Jan 7, 2023
@xaf xaf deleted the xaf/fix_config_parameter_override_by_none branch January 7, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant