Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [bugfix] Control commands weren't reading the delay and bypass parameters #66

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

xaf
Copy link
Owner

@xaf xaf commented Jan 4, 2023

We had support for overriding delay and bypass when receiving a control command, which could be done in an Home Assistant automation for instance to have more control over what qolsysgw supports but that might not be exposable directly to Home Assistant. However, the parameters received from the control command were never read, and thus simply ignored. This fixes that.

…parameters

We had support for overriding `delay` and `bypass` when receiving a
control command, which could be done in an Home Assistant automation
for instance to have more control over what `qolsysgw` supports but
that might not be exposable directly to Home Assistant. However,
the parameters received from the control command were never read,
and thus simply ignored. This fixes that.
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

Coverage

Coverage Report
FileStmtsMissCoverMissing
apps/qolsysgw
   gateway.py1583180%95–96, 131–154, 162, 187–188, 216–217, 226–227, 236–237, 243, 263–264
apps/qolsysgw/mqtt
   exceptions.py80100% 
   listener.py53885%42–44, 68–70, 74–75
   updater.py2271494%184, 187, 214, 222, 227, 232, 236, 241, 273, 335, 340, 418, 460, 508
   utils.py200100% 
apps/qolsysgw/qolsys
   actions.py50296%24, 34
   config.py651282%61–62, 64, 68, 73, 88–100, 110, 139
   control.py151795%39, 47, 51, 58, 65, 81, 88
   events.py2322191%60, 65, 93, 97, 123–124, 156, 160, 183, 194, 201, 225, 241, 255, 268–270, 315, 347, 359, 404
   exceptions.py200100% 
   observable.py17382%13, 17–18
   partition.py120794%149–153, 159–163, 166
   sensors.py1792288%51–72, 116, 120, 126, 155, 159, 164, 179, 183
   socket.py931980%36, 43, 52–54, 83–84, 103–105, 109–110, 114–116, 126–127, 133–134
   state.py50394%18, 52, 60
   utils.py32488%10, 13, 19–20
TOTAL147515390% 

Tests Skipped Failures Errors Time
109 0 💤 0 ❌ 0 🔥 29.226s ⏱️

@xaf xaf changed the title 🐛 [bugfix] Control commands weren't reading the delay and bypass 🐛 [bugfix] Control commands weren't reading the delay and bypass parameters Jan 4, 2023
@xaf xaf merged commit 7046b82 into main Jan 4, 2023
@xaf xaf deleted the xaf/fix_control_command_parameters_being_ignored branch January 4, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant