Skip to content
This repository was archived by the owner on Jul 25, 2023. It is now read-only.

Feat/list sort #19

Merged
merged 7 commits into from
Oct 19, 2022
Merged

Feat/list sort #19

merged 7 commits into from
Oct 19, 2022

Conversation

xNaCly
Copy link
Owner

@xNaCly xNaCly commented Oct 19, 2022 

--sort_by <sort_by>        sort tasks by given param: (id, due, finished, title, priority, tag)
--sort_order <sort_order>  sort direction: (asc, desc)

# sort list output by task property
opus list --sort_by=id
opus list --sort_by=due
opus list --sort_by=finished
opus list --sort_by=title
opus list --sort_by=priority
opus list --sort_by=tag
# sort desc and asc (default sort is asc)
opus list --sort_by=id --sort_mode=desc
# [2]: 'read c how to' (2022-10-17)
# [1]: 'notion aufsetzen' (2022-10-18) #uni .1
# --
# 2 tasks found matching query: 'list'

xNaCly and others added 5 commits October 19, 2022 13:02
@xNaCly
feat: add foundation for sorting
950daf9 
- add command flag --sort_by to clap parsing
- add SortMode and SortDirection enums
- add the above as params to cli::cli_get_tasks, db::Database::get_tasks
@hlxid @xNaCly
test: add missing asserts to task.compare_content() calls (#18)
ec93015 
* test: add missing asserts to task.compare_content() calls

While refactoring the test task compare code into `Task::content_compare`
the asserts went missing (oh no). Adds them back so that if the
comparsion return false the tests will fail.

* test: fix finish_task test
@xNaCly
feat: implemented #16 (sorting for opus list)
c4032a5 
- added two flags to the opus list command:
  --sort_by=<id, due, finished, title, priority, tag>
  --sort_order=<asc, desc>
- renamed SortDirection to SortOrder
- updated tests to include new cli::cli_get_tasks parameters
- changed Database::get_tasks::sql_query to type String
@xNaCly
fix: correct help message for --sort_order
87f3c2a
@xNaCly
doc: added list sorting documentation
4a5cecc
@xNaCly xNaCly linked an issue Oct 19, 2022 that may be closed by this pull request
Add possibility in opus list to sort tasks #16
Closed
hlxid
hlxid reviewed Oct 19, 2022
View reviewed changes
@xNaCly xNaCly merged commit 95d7a21 into master Oct 19, 2022
@xNaCly xNaCly deleted the feat/list-sort branch October 19, 2022 12:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hlxid hlxid hlxid left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add possibility in opus list to sort tasks
2 participants
@xNaCly @hlxid